refactor: find new columns to improve write performance #918
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chunshao90
force-pushed
the
refactor-find-new-columns
branch
from
8c2f601
to
f73501c
Compare
jiacai2050
reviewed
May 24, 2023
jiacai2050
reviewed
May 24, 2023
jiacai2050
reviewed
May 24, 2023
jiacai2050
reviewed
May 24, 2023
chunshao90
force-pushed
the
refactor-find-new-columns
branch
from
9b57bfc
to
a507541
Compare
|
@chunshao90 Could you add the unit for the benchmark results (I guess it should be rows/s)? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issues
Closes #
Detailed Changes
Refactor find new columns to improve write performance.
Test Plan
TSBS.
Benchmark